Use a proper MessageHandler for PartialEvaluator.getTextContent to avoid errors for fonts relying on built-in CMap files (PR 8064 follow-up)
#8194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o avoid errors for fonts relying on built-in CMap files (PR 8064 follow-up) *My apologies for inadvertently breaking this in PR 8064; apparently we don't have any tests that cover this use-case :(* Without this patch `getTextContent` will fail if called before `getOperatorList`, since loading of fonts during text-extraction may require fetching of built-in CMap files. *Please note:* The `text` test added here, which uses an already existing PDF file, fails without this patch.
Snuffleupagus
requested review from
brendandahl,
yurydelendik and
timvandermeij
… the `responseType` in the `DOMCMapReaderFactory`, since IE fails otherwise (issue 8193) I really cannot understand why this change is necessary, since modern browsers such as Firefox and Chrome work just fine with the old code. Hence this is patch is yet another "hack" that's needed just because IE apparently cannot just work like you'd expect. For consistency, the Node factory used in the CMap unit-tests is changed as well. Fixes 8193.
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/767a7afa6a98489/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/5c640bf6c539948/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/5c640bf6c539948/output.txt Total script time: 22.80 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/767a7afa6a98489/output.txt Total script time: 28.89 mins
|
yurydelendik
approved these changes
Mar 25, 2017
|
Thank you for the patch. |
movsb
pushed a commit
to movsb/pdf.js
that referenced
this pull request
Jul 14, 2018
…-proper-handler Use a proper `MessageHandler` for `PartialEvaluator.getTextContent` to avoid errors for fonts relying on built-in CMap files (PR 8064 follow-up)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My apologies for inadvertently breaking this in PR #8064; apparently we don't have any tests that cover this use-case :(
Without this patch
getTextContentwill fail if called beforegetOperatorList, since loading of fonts during text-extraction may require fetching of built-in CMap files.Please note: The
texttest added here, which uses an already existing PDF file, fails without this patch.Given that this patch fixes a bad regression, I'm flagging a bunch of people for review (for whoever has time to look at it first).
Fixes #8193, courtesy of the second commit.
Three cheers for all the idiosyncrasies in IE that made the second patch necessary :-P