Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider foo-\nBar as a compound word #18730

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Consider foo-\nBar as a compound word #18730

merged 1 commit into from
Sep 11, 2024

Conversation

calixteman
Copy link
Contributor

Fixes #18693.

@calixteman
Copy link
Contributor Author

/botio unittest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_unittest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/1085a90fcb045b0/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_unittest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/8d1df830f60320c/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/1085a90fcb045b0/output.txt

Total script time: 2.74 mins

  • Unit Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/8d1df830f60320c/output.txt

Total script time: 8.30 mins

  • Unit Tests: Passed

Snuffleupagus
Snuffleupagus approved these changes Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully this won't break some other case, but I suppose we'll not know that unless we try :-)

r=me, thank you.

test/unit/pdf_find_controller_spec.js Outdated Show resolved Hide resolved
@calixteman
Copy link
Contributor Author

/botio unittest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_unittest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/8b2445050f9103e/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_unittest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/7c7c25359b6ee20/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/8b2445050f9103e/output.txt

Total script time: 2.69 mins

  • Unit Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/7c7c25359b6ee20/output.txt

Total script time: 7.32 mins

  • Unit Tests: Passed

@calixteman calixteman merged commit 870394d into mozilla:master Sep 11, 2024
6 checks passed
@calixteman calixteman deleted the issue18693 branch September 11, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
text-selection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Can not search what I copy text from original pdf file
3 participants
@calixteman @moz-tools-bot @Snuffleupagus