Correct recognition of fragments at document load #16630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`PDFViewerApplication` reads from `location.hash` to initialize `initialBookmark`. But when extensions/chromium/pdfHandler.js prepares the redirect URL, the reference fragment is encoded instead of bare. `rewriteUrlClosure` in `chromecom.js` is responsible for decoding the URL, but that currently runs too late. To fix this, update `initialBookmark` after rewriting the URL. This was not a problem in the past because `rewriteUrlClosure` in `chromecom.js` executed before the initialization of `initialBookmark`.
Semantically, it is more correct to encode the fragment in the URL instead of the URL-encoded `file` query parameter. This shouldn't matter in practice, because `rewriteUrlClosure` in `chromecom.js` decodes the `file` parameter and restores the fragment. However, as mozilla#16625 shows, there was a case where this did not work as expected.
timvandermeij
approved these changes
Jul 8, 2023
|
Thank you for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16625.