Make worker-loader optional as peerDependencies. Close #13825. #13833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
requested changes
Aug 1, 2021
There was a problem hiding this comment.
Please fix the lint failures, see https://github.com/mozilla/pdf.js/pull/13833/files or https://github.com/mozilla/pdf.js/pull/13833/checks?check_run_id=3211936793; you could (most likely) even do that automatically by running gulp lint --fix locally.
tamuratak
force-pushed
the
add_peer_dep_meta_for_worker_loader
branch
from
25e101b
to
9eca5e5
Compare
Snuffleupagus
approved these changes
Aug 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
worker-loaderoptional as peerDependencies. Close #13825.Update
worker-loaderto v3.0.8.