-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the "Select text with the pointer hovering an existing highlight must check that an existing highlight is ignored on hovering" integration test #18775
Comments
I have confirmed in PR #18859 that reverting commit 68332ec indeed fixes the issue. This issue is very similar to #18774 (comment) in that it originates from the same commit, only happens on a specific browser/OS combination and has to do with making a visual selection in the viewer. It's therefore likely that fixing one of them will also fix the other. |
I tried to reproduce it yesterday on Windows and I didn't manage to. |
This integration test fails consistently on only the Windows bot with the following traceback (see http://54.193.163.58:8877/662f7dec318944a/output.txt):
The earliest occurrence I could find of this test failure is #18698 (comment), so perhaps that patch introduced a regression (other than #18716). We could try to check if it still fails without that patch, and if so we might have a better idea about what changed.
PR #18721 attempts to debug/resolve this issue.
The text was updated successfully, but these errors were encountered: