[Chrome extension] Attempt to migrate the old `showPreviousViewOnLoad…

…`/`disablePageMode` preferences to the new `viewOnLoad` preference This patch ignores the recently added `disableOpenActionDestination` preference, since the latest PDF.js version found on the "Chrome Web Store" doesn't include it.
mozilla · Jan 28, 2019 · fbfb4da · fbfb4da
1 parent 66deea1
commit fbfb4da
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 0 deletions.
diff --git a/extensions/chromium/options/migration.js b/extensions/chromium/options/migration.js
@@ -81,6 +81,9 @@ limitations under the License.
       'disableTextLayer',
       'enhanceTextSelection',
       'textLayerMode',
+      'showPreviousViewOnLoad',
+      'disablePageMode',
+      'viewOnLoad',
     ], function(items) {
       // Migration code for https://github.com/mozilla/pdf.js/pull/7635.
       if (typeof items.enableHandToolOnLoad === 'boolean') {
@@ -113,6 +116,20 @@ limitations under the License.
           storageSync.remove(['disableTextLayer', 'enhanceTextSelection']);
         }
       }
+      // Migration code for https://github.com/mozilla/pdf.js/pull/10502.
+      if (typeof items.showPreviousViewOnLoad === 'boolean') {
+        if (!items.showPreviousViewOnLoad) {
+          storageSync.set({
+            viewOnLoad: 1,
+          }, function() {
+            if (!chrome.runtime.lastError) {
+              storageSync.remove(['showPreviousViewOnLoad', 'disablePageMode']);
+            }
+          });
+        } else {
+          storageSync.remove(['showPreviousViewOnLoad', 'disablePageMode']);
+        }
+      }
     });
   }
 })();
diff --git a/web/chromecom.js b/web/chromecom.js
@@ -341,6 +341,8 @@ class ChromePreferences extends BasePreferences {
           enableHandToolOnLoad: false,
           disableTextLayer: false,
           enhanceTextSelection: false,
+          showPreviousViewOnLoad: true,
+          disablePageMode: false,
         }, this.defaults);
 
         chrome.storage.managed.get(defaultManagedPrefs, function(items) {
@@ -370,6 +372,13 @@ class ChromePreferences extends BasePreferences {
           delete items.disableTextLayer;
           delete items.enhanceTextSelection;
 
+          // Migration code for https://github.com/mozilla/pdf.js/pull/10502.
+          if (!items.showPreviousViewOnLoad && !items.viewOnLoad) {
+            items.viewOnLoad = 1;
+          }
+          delete items.showPreviousViewOnLoad;
+          delete items.disablePageMode;
+
           getPreferences(items);
         });
       } else {