use === and !== instead == and != #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Same thing happened here, it's showing 3 commits for some reason. |
|
It has been rebased. |
| @@ -511,7 +511,7 @@ var Compiler = Object.extend({ | |||
| var name = target.value; | |||
| var id = frame.lookup(name); | |||
|
|
|||
| if (id == null) { | |||
| if (id === null || id === undefined) { | |||
There was a problem hiding this comment.
I'm actually open to still using == for checking null/undefined. It gets annoying to always have to check for both, and once you learn that == matches both, I don't think its too confusing. That's the only case I'd want to use ==. What do you think (others who see this, feel free to comment too)?
There was a problem hiding this comment.
The practice leads us to always use === that == will confuse other what is exactly equal to.
But it works fine in this case.
jlongster
added a commit
that referenced
this pull request
Mar 10, 2015
use === and !== instead == and !=
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split PR from #383
Based on #385 and #386, merge this PR after that.