precompile.js TypeError: name.replace is not a function

[nigelmegitt]

I'm getting a runtime error running precompile.js on line 114.

Command line:

$ node_modules/nunjucks/bin/precompile input_template.xml > output_template.js

gives a TypeError in the function _precompile when it tries to call:

  name = name.replace(/\\/g, '/');

Debugging, this is because further up the stack, in the precompile function, line 85, the call to _precompile passes in as the second argument opts.name || input. Whilst input is indeed my input filename string, opts.name is a function pointer, not a string. Replacing this text with opts.name() || input appears to fix the problem, though I'm not familiar enough with the codebase to understand if that is the right place to make the fix.

In my case opts.name() returns undefined, which means the input filename gets used instead.

nunjucks release 3.2.1
node v12.7.0

Stack trace:

  name = name.replace(/\\/g, '/');
              ^

TypeError: name.replace is not a function
    at _precompile (/XXX/node_modules/nunjucks/src/precompile.js:114:15)
    at precompile (/XXX/node_modules/nunjucks/src/precompile.js:85:22)
    at Object.<anonymous> (/XXX/node_modules/nunjucks/bin/precompile:45:13)
    at Module._compile (internal/modules/cjs/loader.js:777:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:788:10)
    at Module.load (internal/modules/cjs/loader.js:643:32)
    at Function.Module._load (internal/modules/cjs/loader.js:556:12)
    at Function.Module.runMain (internal/modules/cjs/loader.js:840:10)
    at internal/main/run_main_module.js:17:11

[nigelmegitt]

Further digging: making the simple change I proposed did not work in #1296, because when the -name option is specified, opt.name is a string not a function pointer. This problem is absent in release 3.2.0, and was likely introduced by 93129bf when yargs was replaced with commander by @AlynxZhou and @fdintino - mentioning you here in case you can shed any further light on this, or fix the issue.

It seems to me that regardless of whether -name is specified on the command line or not, the value of opts.name should not end up being a function pointer: it should be undefined or a string.

[AlynxZhou]

Hi, I am on trip today and I will try to fix this bug tomorrow. Thanks!

…

On Tue, Jul 7, 2020, 19:32 Nigel Megitt ***@***.***> wrote: Further digging: this problem is absent in release 3.2.0, and was likely introduced by 93129bf <93129bf> when yargs was replaced with commander <https://www.npmjs.com/package/commander> by @AlynxZhou <https://github.com/AlynxZhou> and @fdintino <https://github.com/fdintino> - mentioning you here in case you can shed any further light on this, or fix the issue. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1295 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACANVR57236NGASKKWNLD63R2MBWNANCNFSM4OSTTYKA> .