Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Django to 2.2 #1834

Closed
mythmon opened this issue Apr 1, 2019 · 2 comments · Fixed by #1921
Closed

Upgrade Django to 2.2 #1834

mythmon opened this issue Apr 1, 2019 · 2 comments · Fixed by #1921

Comments

@mythmon
Copy link
Contributor

mythmon commented Apr 1, 2019

In #1832, pyup tried to update Django to 2.2. That caused a bunch of test failures I had trouble resolving locally. In the interest of not leaving things open, I pulled out that upgrade to handle it in a separate branch.
@mythmon
Copy link
Contributor Author

mythmon commented Apr 4, 2019

After spending significant time on this, I think that there is either a bug in Django 2.2, or a very subtle bug in Normandy. I wasn't able to reproduce the bug in a small test project though, so I'm not going to file a bug.

For now, I'm going to wait until 2.2.1 is released, and hope it fixes the issue we saw, or more people on the internet have a chance to upgrade and can reveal what we did wrong.

@rehandalal
Copy link
Contributor

Seems to be resolved in 2.2.3

@rehandalal rehandalal mentioned this issue Jul 8, 2019
Merged
bors bot added a commit that referenced this issue Jul 8, 2019
@bors @rehandalal
Merge #1921
66c9cf5 
1921: Upgrade Django to 2.2.3 r=mythmon a=rehandalal

There's a security vulnerability in our current version of Django.

Fixes #1834.

r?

Co-authored-by: Rehan Dalal <[email protected]>
@bors bors bot closed this as completed in #1921 Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade Django to 2.2.3
2 participants
@mythmon @rehandalal