Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility warning with nixpkgs >= NixOS 24.11 #332

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

FPtje
Copy link

@FPtje FPtje commented Oct 18, 2024

When using nixpkgs-unstable or NixOS 24.11 (not released as of writing), using the rust overlay leads to the following deprecation warning:

evaluation warning: `rust.toRustTarget platform` is deprecated. Use `platform.rust.rustcTarget` instead.
evaluation warning: `rust.toRustTarget platform` is deprecated. Use `platform.rust.rustcTarget` instead.
evaluation warning: `rust.toRustTarget platform` is deprecated. Use `platform.rust.rustcTarget` instead.
evaluation warning: `rust.toRustTarget platform` is deprecated. Use `platform.rust.rustcTarget` instead.
evaluation warning: `rust.toRustTarget platform` is deprecated. Use `platform.rust.rustcTarget` instead.
evaluation warning: `rust.toRustTarget platform` is deprecated. Use `platform.rust.rustcTarget` instead.

Note that in my case, the warning is indeed repeated six times.

The reason why this happens can be seen in this particular release note:

  • The rust.toTargetArch, rust.toTargetOs, rust.toTargetFamily, rust.toTargetVendor, rust.toRustTarget, rust.toRustTargetSpec, rust.toRustTargetSpecShort, and rust.IsNoStdTarget functions are deprecated in favour of the rust.platform.arch, rust.platform.os, rust.platform.target-family, rust.platform.vendor, rust.rustcTarget, rust.rustcTargetSpec, rust.cargoShortTarget, rust.cargoEnvVarTarget, and rust.isNoStdTarget platform attributes respectively.

https://github.com/NixOS/nixpkgs/blob/7881fbfd2e3ed1dfa315fca889b2cfd94be39337/nixos/doc/manual/release-notes/rl-2411.section.md#L293

Since this repo only ever calls rust.toRustTarget, that is the only thing that needs migrating.

Note that the toRustTargetCompat should make sure that the overlay keeps working, even if one is running an older version of Nixpkgs. This seems useful for users of the overlay, as otherwise just updating nixpkgs-mozilla without updating nixpkgs would cause a rather complex evaluation error.

This includes some revisions of nixpkgs-unstable before the release of
NixOS 24.11.

The precise warning is as follows:

evaluation warning: `rust.toRustTarget platform` is deprecated. Use `platform.rust.rustcTarget` instead.

This provides compatibility with older versions of nixpkgs, which may
not have `platform.rust.rustcTarget` in the first place.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant