No need to borrow with a smarter borrow checker #2238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinthomson
requested review from
KershawChang,
larseggert and
mxinden
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2238 +/- ##
==========================================
- Coverage 95.37% 95.37% -0.01%
==========================================
Files 112 112
Lines 36570 36569 -1
==========================================
- Hits 34880 34879 -1
Misses 1690 1690 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Benchmark resultsPerformance differences relative to 7a25525. coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [91.139 ns 91.459 ns 91.791 ns]
change: [-0.3806% +0.1234% +0.6454%] (p = 0.65 > 0.05)
coalesce_acked_from_zero 3+1 entries: Change within noise threshold. time: [101.48 ns 101.73 ns 102.02 ns]
change: [+0.3223% +0.8134% +1.3738%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 10+1 entries: Change within noise threshold. time: [101.16 ns 101.60 ns 102.15 ns]
change: [+0.4288% +0.9242% +1.4474%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [82.190 ns 82.324 ns 82.484 ns]
change: [-1.3048% -0.1644% +1.0067%] (p = 0.79 > 0.05)
RxStreamOrderer::inbound_frame(): Change within noise threshold. time: [112.08 ms 112.22 ms 112.43 ms]
change: [+0.0673% +0.3125% +0.5796%] (p = 0.00 < 0.05)
transfer/pacing-false/varying-seeds: No change in performance detected. time: [26.205 ms 27.392 ms 28.571 ms]
change: [-7.5419% -2.4149% +3.0206%] (p = 0.39 > 0.05)
transfer/pacing-true/varying-seeds: No change in performance detected. time: [34.199 ms 35.903 ms 37.616 ms]
change: [-6.1807% +0.3482% +7.4886%] (p = 0.93 > 0.05)
transfer/pacing-false/same-seed: No change in performance detected. time: [26.496 ms 27.315 ms 28.126 ms]
change: [-3.8987% +0.5000% +4.5704%] (p = 0.82 > 0.05)
transfer/pacing-true/same-seed: No change in performance detected. time: [41.871 ms 44.063 ms 46.314 ms]
change: [-4.3002% +2.9109% +10.536%] (p = 0.42 > 0.05)
1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: 💚 Performance has improved. time: [905.39 ms 914.10 ms 922.95 ms]
thrpt: [108.35 MiB/s 109.40 MiB/s 110.45 MiB/s]
change:
time: [-4.7156% -3.4378% -2.0642%] (p = 0.00 < 0.05)
thrpt: [+2.1077% +3.5602% +4.9489%]
1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: No change in performance detected. time: [320.25 ms 323.69 ms 327.20 ms]
thrpt: [30.562 Kelem/s 30.894 Kelem/s 31.225 Kelem/s]
change:
time: [-2.2118% -0.8998% +0.4615%] (p = 0.20 > 0.05)
thrpt: [-0.4594% +0.9079% +2.2619%]
1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: No change in performance detected. time: [33.387 ms 33.570 ms 33.764 ms]
thrpt: [29.618 elem/s 29.789 elem/s 29.951 elem/s]
change:
time: [-1.4631% -0.6987% +0.0848%] (p = 0.08 > 0.05)
thrpt: [-0.0847% +0.7036% +1.4848%]
1-conn/1-100mb-resp/mtu-1504 (aka. Upload)/client: 💚 Performance has improved. time: [1.5904 s 1.6078 s 1.6254 s]
thrpt: [61.522 MiB/s 62.198 MiB/s 62.878 MiB/s]
change:
time: [-5.3510% -3.9087% -2.3384%] (p = 0.00 < 0.05)
thrpt: [+2.3944% +4.0677% +5.6535%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
Failed Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
larseggert
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stuff like this is not needed when your borrow checker gets upgraded.