Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix empty regexp and incoming sync exclude behavior #2383

Merged
merged 1 commit into from
Jul 6, 2022
Merged

Fix empty regexp and incoming sync exclude behavior #2383

merged 1 commit into from
Jul 6, 2022

Conversation

stoically
Copy link
Member

@stoically stoically commented Jun 24, 2022 •
edited
Loading

  • Leaving the regexp empty would no longer sync any outgoing container
  • Incoming containers should get excluded as well
  • Cover the scenarios with tests

Follow-up from #2231.

@stoically stoically force-pushed the sync-exclude-empty-fix branch from 266b3b9 to ec414a7 Compare June 24, 2022 12:36
@stoically stoically changed the title Fix empty sync exclude regexp behavior Fix empty regexp and incoming sync exclude behavior Jun 24, 2022
@stoically stoically force-pushed the sync-exclude-empty-fix branch 6 times, most recently from 0a7e2d6 to 670a7e8 Compare June 24, 2022 14:20
@dannycolin dannycolin self-requested a review June 24, 2022 22:39
dannycolin
dannycolin reviewed Jul 6, 2022
View reviewed changes
src/js/background/sync.js Show resolved Hide resolved
src/js/background/sync.js Outdated Show resolved Hide resolved
@stoically stoically force-pushed the sync-exclude-empty-fix branch from 670a7e8 to 6021af1 Compare July 6, 2022 15:59
@stoically stoically merged commit e5fa98d into mozilla:main Jul 6, 2022
@stoically stoically deleted the sync-exclude-empty-fix branch July 6, 2022 23:40
Nomes77 added a commit to Nomes77/multi-account-containers that referenced this pull request Jul 29, 2022
@Nomes77
Fix empty sync exclude regexp behavior
3d02d64 
mozilla#2383
@dannycolin dannycolin mentioned this pull request Nov 11, 2022
Closed
@mitchcurtis mitchcurtis mentioned this pull request Nov 18, 2022
Open
dannycolin added a commit to dannycolin/multi-account-containers that referenced this pull request Nov 19, 2022
@dannycolin
Revert "Fix empty sync exclude regexp behavior (mozilla#2383)"
06c8975 
This reverts commit e5fa98d.
@dannycolin dannycolin mentioned this pull request Nov 19, 2022
Merged
Nomes77 added a commit to Nomes77/multi-account-containers that referenced this pull request Dec 5, 2022
@Nomes77
Revert "Fix empty sync exclude regexp behavior (mozilla#2383)"
2960e5c 
mozilla@06c8975
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannycolin dannycolin dannycolin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stoically @dannycolin