Make proxy & nativeMessaging permissions optional #2225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bakulf
force-pushed
the
make-proxy/nativeMessaging-optional
branch
5 times, most recently
from
f8821ba to
9065790
Compare
lesleyjanenorton
force-pushed
the
make-proxy/nativeMessaging-optional
branch
from
3c4cd46 to
7422dc8
Compare
- Badge the Options icon when proxy and/or nativeMessaging permissions are disabled. Remove on click, don't show again. - Use localized strings - Refactors + cleanup
lesleyjanenorton
force-pushed
the
make-proxy/nativeMessaging-optional
branch
from
e52a33a to
8e51ea0
Compare
lesleyjanenorton
changed the title
This prevents permission prompts from getting lost when multiple permission checkboxes are checked before their corresponding prompts are accepted or declined and one of the permissions requires a reboot when enabled (Jira ticket MAC-689)
bakulf
approved these changes
Dec 14, 2021
src/js/mozillaVpn.js
Outdated
| @@ -156,6 +161,12 @@ const MozillaVPN = { | |||
| }; | |||
| }, | |||
|
|
|||
| async bothPermissionsEnabled() { | |||
| const proxyPermissionEnabled = await browser.permissions.contains({ permissions: ["proxy"] }); | |||
There was a problem hiding this comment.
Let's use promise.all and contains (false). I can update this.
WhyNotHugo
reviewed
Dec 14, 2021
| @@ -1,29 +1,122 @@ | |||
| body { | |||
| --grey10: #e7e7e7; | |||
|
|
|||
| font-family: -apple-system, BlinkMacSystemFont, 'Segoe UI', Roboto, Oxygen, Ubuntu, Cantarell, 'Open Sans', 'Helvetica Neue', sans-serif; | |||
There was a problem hiding this comment.
system-ui is the equivalent of -apple-system on Linux, and results in the same font that's used by the current desktop theme by default.
bakulf
force-pushed
the
make-proxy/nativeMessaging-optional
branch
from
b8560ff to
f544f41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes
proxyandnativeMessagingpermissions optional instead of required.It also updates the UI to accommodate these changes and provide visual cues and easy paths to enabling these permissions for folks who want to make use of the Mozilla VPN integration and/or custom proxy feature.
Options
Onboarding:
Permissions nudges
Strings for this feature are here
Fixes #2240, #2226
🟢 Green light from QA
Closes MAC-689, MAC-686, MAC-683, MAC-682, MAC-680, MAC-684, MAC-674, MAC-675, MAC-676, MAC-677, MAC-678