Cancel requests with the same requestId #1114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stoically
force-pushed
the
cancel-already-handled-requests
branch
6 times, most recently
from
69493f7 to
4af28a1
Compare
Prevents potential redirects from opening two tabs Closes mozilla#1114
stoically
force-pushed
the
cancel-already-handled-requests
branch
from
4af28a1 to
db35abb
Compare
jonathanKingston
approved these changes
Feb 9, 2018
|
I agree that a timeout to clean up is not a clean solution - unfortunately I couldn't think of something else to handle this in the WebExtension, since we have no knowledge how many onBeforeRequest handlers are registered. So in theory any number of redirects depending on the number of Add-ons can happen. Same applies for 302 redirects, since there could also be multiple ones. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents potential redirects from opening two tabs. Detailed explanation is here.
Added also a test to #1107 which you can see fail without this fix.
Affects #940 #1003 #1080 - but doesn't fully fix them. Fewer people should be affected by two tabs opening especially in combination with Add-ons that redirect.