Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refreshing a website assigned to a different container wrongly opens the "Containers confirm navigation" page in a new tab #635

Closed
Softvision-VladBacia opened this issue Jun 23, 2017 · 4 comments
Assignees
Labels
bug Something is broken!

Comments

@Softvision-VladBacia
Copy link

Softvision-VladBacia commented Jun 23, 2017

[Affected versions]:

  • Firefox 54 and up
  • Containers Experiment Build: 2.4.0

[Affected Platforms]:

  • All Windows
  • All Linux
  • All Mac

[Prerequisites]:

  • Containers Experiment is installed on a new browser profile.

[Steps to reproduce]:

  1. Start the browser with the profile from prerequisites.
  2. Open the same website in 2 different containers.
  3. Assign the website to always open in the first container.
  4. Refresh the page in the second container.
  5. Observe the results.

[Expected results]:

  • Container confirm navigation tab, replaces the page for which the refresh was made.

[Actual results]:

  • After the page refresh is initialized, the "Container confirm navigation" page is opened in a new tab.

[Notes]:

  • Attached a screen recording of the issue:
    refresh in the same tab
@ArchangeGabriel
Copy link

I would say that the opening in a new tab is expected, unless a way to switch a tab from container has been implemented.

However, the issue I see here is that the new tab is not in the right container.

@jonathanKingston
Copy link
Contributor

This seems a lot like: #626 I guess we didn't fix it there?
Will check this out anyway.

@jonathanKingston
Copy link
Contributor

Sorry I understand this now, it is kinda expected.

Currently we allow "Exemptions" to assignment, issues I see with this related to this and other bugs that might come up:

  1. Exemptions are not stored, which means on session restore the approve screen will show
  2. On refreshing existing tabs the exemptions are not added on assignment to the exemption list.
  3. Exemptions don't persist on opening a new tab (ctrl+click etc)

The issue here is 2. and I think we can fix this when the user assigns the tab.

  1. and 3 I'm not sure are going to be solvable.

@jonathanKingston jonathanKingston added the bug Something is broken! label Jun 23, 2017
jonathanKingston added a commit to jonathanKingston/multi-account-containers that referenced this issue Jun 23, 2017
@SoftVision-CiprianMuresan

The issue is no longer reproducible on the latest Containers add-on built on 6/28/2017.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken!
Projects
None yet
Development

No branches or pull requests

4 participants