Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Ask in which container to open a link or new tab #2001

Open
naoliden opened this issue Mar 28, 2021 · 11 comments
Open

Feature Request: Ask in which container to open a link or new tab #2001

naoliden opened this issue Mar 28, 2021 · 11 comments
Labels
Needs: Mozilla Central Needs changes in Mozilla-Central 👍 Feature Request Feature requests users would like to see in this addon

Comments

@naoliden
Copy link

naoliden commented Mar 28, 2021

I would like to request options for the following cases:

1- If I'm opening a link from another app (like email or whatsapp), it asks in which container to open the link.
2- If I open a new tab and type an address, ask in which container to open the site.

3- When selecting the option "reopen in Container....", it replaces the current tab which a tab opened in the selected container. (I believe it's already implemented, but it doens't work on my pc)

┆Issue is synchronized with this Jira Task

@brichris
Copy link

brichris commented Apr 8, 2021

Definitely this! I'd add one more thing: Have Firefox prompt for which container to use (if any) when the Firefox application is simply opened from scratch (opened from being fully closed). Of course, this could be an option which users can choose to enable (or not).

@grahamperrin
Copy link

This is probably more for Mozilla Firefox to solve, than for any extension. Please see for example:

@ncallaway
Copy link

ncallaway commented Apr 25, 2021

@grahamperrin I'm a little confused by your response. I'm probably just misreading somehow.

Here you seem to be saying that this is an issue that's better dealt with in Firefox than in an extension, but it the bugzilla issue you linked, you're also responding by pointing to an extension that appears to be doing this.

Were you saying it's technically not feasible for an extension to do this, or is it more that there's an architectural or structural preference for this being done in the core browser rather than an extension? Again, sorry if I misread something!

@grahamperrin
Copy link

grahamperrin commented Apr 25, 2021

My apologies for lack of clarity.

I'm not a developer, but I believe that there's scope for Firefox code to be enhanced with regard to links from external applications. Not solely for Multi-Account Containers; with Google Chrome parity (parity-chrome) in mind there's also this, for example:

So it should be possible for link that's opened in Thunderbird (or Outlook or whatever) to be gracefully 'routed' to a group and a container, in Firefox, without requiring the user to manually organise both things after the page loads.

(After the event is less graceful; potentially annoying.)

Mozilla bug 1692124 suggests a best-guess approach, for containers.


Whilst Always In Container makes no attempt to guess, it can (at least) ask in which container to open a link or new tab.

@ncallaway
Copy link

Gotcha, makes sense! Thanks

@grahamperrin
Copy link

@naoliden
Copy link
Author

@grahamperrin wouldn't there be any security issues using Always in Container?
Multi Account Containers is monitored by Mozilla but Always in Container is not.

@LinuxPanda
Copy link

A default option to always open links in "no container" by default irrespective of whatever container the link is opened from except in case if the domain is set to "always open in x container" would be nice.

@grahamperrin
Copy link

… open links in "no container" by default irrespective of whatever container the link is opened from except in case if the domain is set to "always open in x container" …

▶ 2017 issue mozilla/addons-frontend#434 also known as Mozilla bug 1355433 - Add preference to disable "related tab" code opening in the same container – please join the discussion there. Thank you.

@grahamperrin
Copy link

grahamperrin commented Apr 27, 2021

#2001 (comment)

wouldn't there be any security issues using Always in Container?

tiansh/always-in-container#7

Code

Multi Account Containers

Always In Container uses the OSI-approved Mozilla Public License, version 2.0.

Multi-Account Containers may benefit from the code.

Terminology

Multi-Account Containers is monitored by Mozilla …

Monitored … most often means an extension that is recommended. LASER CAT is recommended, for example. mozilla/addons#13725 is part of the history through which certain phrases and meanings stuck in people's minds.

Strictly speaking: Multi-Account Containers is by Firefox.

Add-on Badges | Firefox Help

@naoliden
Copy link
Author

So @grahamperrin, just so I that understand...
The answer would be installing the Switch-Container and Always-in-Container Add-ons?
Can these be included among MAC features?
Also, I know that MAC already has a "Reopen this site in..." function, but I can't make it so it closes the previous tab, it has the option in settings, but I don't know why it doesn't work on my PC.

@dannycolin dannycolin added 👍 Feature Request Feature requests users would like to see in this addon Needs: Mozilla Central Needs changes in Mozilla-Central labels Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Mozilla Central Needs changes in Mozilla-Central 👍 Feature Request Feature requests users would like to see in this addon
Projects
None yet
Development

No branches or pull requests

6 participants