Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adhoc-sign: update signing format for Windows (bug 1931584) #1878

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

zzzeid
Copy link
Collaborator

@zzzeid zzzeid commented Nov 15, 2024

No description provided.

@zzzeid zzzeid marked this pull request as ready for review November 15, 2024 17:28
@zzzeid zzzeid requested a review from jmaher November 21, 2024 20:53
Copy link

@hneiva hneiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zzzeid zzzeid requested a review from cgsheeh November 21, 2024 20:55
Copy link
Collaborator

@jmaher jmaher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@zzzeid zzzeid merged commit ec74e40 into main Nov 22, 2024
21 checks passed
@zzzeid zzzeid deleted the zeid/bug-1931584-fix-signing branch November 22, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants