CLEANER PR for #856 the new homepage implementation #952
Conversation
…nly contains miminal changes needed for the new homepage
|
@toolness LET'S GET THIS PUSHEDDDDD! |
(well, after I get a R+ of course)
| @@ -22,6 +22,8 @@ to [Semantic Versioning](http://semver.org/). | |||
| accessible. | |||
|
|
|||
| ### Changed | |||
| - The homepage has been refreshed to better inform | |||
| the site vistors what they can do on the site. | |||
There was a problem hiding this comment.
Aw yeah, right up at the top! 😋
Er can you make the second line indented so it is flush with the first letter of the previous line? Like all the other bullet points below are? Also mention that it shows the latest BLOG POSTS!!!!!!!!!!!
There was a problem hiding this comment.
oh yea, meant to have indentation, I was just careless.
|
Woot this is looking good and super clean, I will manually test it to make sure everything looks good. |
|
This looks A ⭐ W ⭐ S ⭐ M, great work @mmmavis! Feel free to merge once Travis is happy. |
|
Haha no worries, I actually thought it was kinda fun :) Yay teamwork! Good question about pushing the homepage... I guess I recommend including #950 before we formally push to production, but that said, if the teach team REALLY wants their new homepage ASAP, it's probably OK for now to actually just push without #950, since our "fake feed" actually contains all the latest posts. We could even manualy "update" the fake feed to keep up with the blog, lol. I guess that is an unintentional side benefit of our approach that we hadn't considered. |
|
Would be rad to push sooner rather than later. :) |
|
Ah yea sounds good to me! I will bust out a new release in a bit. |
|
Thanksssss. I will get to #950 tomorrow! 👯 👯 👯 👯 👯 |
CLEANER PR for #856 the new homepage implementation
|
M-E-R-G-E-D |
| @@ -22,6 +22,9 @@ to [Semantic Versioning](http://semver.org/). | |||
| accessible. | |||
|
|
|||
| ### Changed | |||
| - Homepage has been refreshed to better inform | |||
There was a problem hiding this comment.
Ack lol I didn't actually look to make sure your new bullet points were being added to the "Unreleased" section--you added them to the release notes for our last release :) Fixed this in e3ac628
There was a problem hiding this comment.
oops, sorry should've been more careful. thanks Atul
There was a problem hiding this comment.
is ok, it was your first time editing the changelog 🍔
My original PR is getting messier and messier and it's very painful for people to understand(sorry 😬 ).
This PR contains minimal changes needed for the new homepage implementation and hopefully it will be a lot easier to understand.