This repository has been archived by the owner on Mar 5, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 91
Upgrade to react 0.13 and dependencies #692
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Hey @k88hudson, curious what you think of this, since a lot of this code is testing code, and you're familiar w/ both react and react-router. |
Conflicts: gulpfile.js package.json pages/clubs.jsx
toolness
changed the title
[WIP] Upgrade to react 0.13 and dependencies
Upgrade to react 0.13 and dependencies
Apr 17, 2015
Ok, I think this is ready for review. @ScottDowne can you take a look? |
By the way, whoever reviews this (and also, once it is merged) may need to manually |
It worked otherwise, just visual quirks. |
Conflicts: package.json
That seems to have done the trick, looks good now. R+ |
toolness
added a commit
that referenced
this pull request
Apr 22, 2015
Upgrade to react 0.13 and dependencies
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #294 and upgrades us to React 0.13, as well as the latest versions of
react-bootstrap
,react-ga
,react-router
, andreact-select
.In general this consisted of the following changes:
getChildContext
always returns the exact same properties in tests to avoid spurious Parent vs. Owner Context warnings.react-router
's new use ofthis.context.router
instead of theRouter.State
andRouter.Navigation
mixins. This entailed creating a newStubRouter
class for our tests.In general, having the really good test coverage of our front-end codebase really helped here, as it surfaced problems very quickly.