Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds relative inferences for DAU statistic #2047

Merged
merged 2 commits into from
Jun 6, 2024
Merged

Adds relative inferences for DAU statistic #2047

merged 2 commits into from
Jun 6, 2024

Conversation

danielkberry
Copy link
Contributor

@danielkberry danielkberry commented Jun 5, 2024

@danielkberry
Copy link
Contributor Author

@mikewilli I'm not sure why the integration test is failing... I didn't touch the requirements file here

@danielkberry
Copy link
Contributor Author

@mikewilli I'm not sure why the integration test is failing... I didn't touch the requirements file here

It's also not clear to me why only the integration tests are failing and not the unit tests.

Copy link
Contributor

@mikewilli mikewilli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good, I'll see if I can figure out why the tests are failing..

@mikewilli
Copy link
Contributor

So I'm able to reproduce this locally with a new venv by just running python -m pip install -r requirements.txt, both on this branch and on main. I found a discussion and an open bug with pip, and the workaround mentioned there of using --no-deps with pip install fixes the problem for me. I don't see a downside to this for us because we are resolving dependencies with pip-tools generating the requirements.txt, so I think it's a valid workaround for us.

I'll put up a quick PR with this change shortly and then hopefully updating this branch with that change fixes the issue.

Still not sure why this suddenly popped up now. Perhaps some cached dependencies that expired or a particular dep update.

@danielkberry danielkberry added this pull request to the merge queue Jun 6, 2024
Merged via the queue into main with commit 9223308 Jun 6, 2024
2 checks passed
@danielkberry danielkberry deleted the dou_to_dau branch June 6, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants