Skip to content
This repository has been archived by the owner on Sep 3, 2020. It is now read-only.

Implement "action" argument for authorize endpoint #131

Closed
toolness opened this issue Apr 6, 2015 · 2 comments
Closed

Implement "action" argument for authorize endpoint #131

toolness opened this issue Apr 6, 2015 · 2 comments
Assignees

Comments

@toolness
Copy link
Contributor

toolness commented Apr 6, 2015

On the teach site, there are two different ways a user could end up at the oauth2 authorize endpoint on id.webmaker.org:

  • By clicking the "login" link, in which case the user expects to be prompted for their username/password.
  • By clicking the "sign up" link, in which case the user expects to sign up.

I'm thinking that this intent could be conveyed by an intent argument to the authorize endpoint. For example, intent=login could indicate to the authorize endpoint that the user wants to login, while intent=signup could indicate that the user wants to sign up.

I'm thinking it could be the burden of the oauth2 client (not id.webmaker.org) to keep track of what the original intent was when the oauth2 callback is triggered. In other words, id.webmaker.org doesn't need to pass intent back to the callback when the user is done logging in or signing up.

This should be documented in docs/oauth.md too.

@toolness
Copy link
Contributor Author

toolness commented Apr 6, 2015

Alternatively, we could call the argument action and do things the exact same way as the fx accounts folks: https://github.com/mozilla/fxa-oauth-server/blob/master/docs/api.md#request-parameters-4

@secretrobotron secretrobotron added this to the Teach QA and Launch milestone Apr 7, 2015
toolness added a commit that referenced this issue Apr 8, 2015
This documents the change required for #131.
@toolness toolness changed the title Implement and document "intent" argument for authorize endpoint Implement and document "action" argument for authorize endpoint Apr 8, 2015
@toolness
Copy link
Contributor Author

toolness commented Apr 8, 2015

Ok, we added documentation for this in #189, and I added teach-api support in mozilla/teach-api@d8812c7 and teach.webmaker.org support in toolness/teach.webmaker.org@247170f. The front-end with OAuth2 enabled is (temporarily) at http://mozteach.toolness.org/, so as soon as things are deployed to id.mofostaging.net, everything should work!

@toolness toolness changed the title Implement and document "action" argument for authorize endpoint Implement "action" argument for authorize endpoint Apr 9, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants