Room UI Redesign: Leave Room Modal #3255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnshaughnessy
approved these changes
Nov 12, 2020
| @@ -1306,7 +1306,7 @@ class UIRoot extends Component { | |||
| label: "Create Room", | |||
| icon: HomeIcon, | |||
| onClick: () => | |||
| this.showNonHistoriedDialog(LeaveRoomDialog, { | |||
| this.showNonHistoriedDialog(LeaveRoomModal, { | |||
There was a problem hiding this comment.
Might also be good to flow thru this modal as a confirmation step for visiting rooms via a room link. I've accidentally clicked one before and it would have been nice to back out of it.
There was a problem hiding this comment.
Hmm, that would break the flow of things like Chamberlain's lighthouse experience though. I don't know that I agree with this, but I'd be happy to follow up discussion in another issue.
| }, | ||
| "create-room-confirm": { | ||
| id: "leave-room-dialog.create-room.confirm", | ||
| defaultMessage: "Leave Room" |
There was a problem hiding this comment.
The title and confirmation button text for this case are awkward. I know this is taken from what we already have, but it seems like the button text or title should be something like "Create Room" or possibly "Leave and Create New Room"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the Leave Room Modal to the new design. It is dependent on #3245