-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Room UI Redesign: Leave Room Modal #3255
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
1326a5d
Add LeaveRoomModal
robertlong 7210fe9
Merge branch 'room-ui-redesign' into redesign/leave-room-modal
robertlong d10e309
Merge branch 'room-ui-redesign' into redesign/leave-room-modal
robertlong 7e6f0ca
Merge branch 'room-ui-redesign' into redesign/leave-room-modal
robertlong ebc4f22
Fix messages and use string enums
robertlong 02d015d
Merge branch 'room-ui-redesign' into redesign/leave-room-modal
robertlong d1b5523
Merge branch 'room-ui-redesign' into redesign/leave-room-modal
robertlong a06831c
Merge branch 'room-ui-redesign' into redesign/leave-room-modal
robertlong File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
import React from "react"; | ||
import styles from "./LeaveRoomModal.scss"; | ||
import { useIntl, defineMessages } from "react-intl"; | ||
import PropTypes from "prop-types"; | ||
import { Modal } from "../modal/Modal"; | ||
import { CloseButton } from "../input/CloseButton"; | ||
import { Button } from "../input/Button"; | ||
|
||
export const LeaveReason = { | ||
joinRoom: "joinRoom", | ||
createRoom: "createRoom" | ||
}; | ||
|
||
const reasonMessages = defineMessages({ | ||
[LeaveReason.joinRoom]: { | ||
id: "leave-room-dialog.join-room.message", | ||
defaultMessage: "Joining a new room will leave this one. Are you sure?" | ||
}, | ||
[LeaveReason.createRoom]: { | ||
id: "leave-room-dialog.create-room.message", | ||
defaultMessage: "Creating a new room will leave this one. Are you sure?" | ||
} | ||
}); | ||
|
||
const confirmationMessages = defineMessages({ | ||
[LeaveReason.joinRoom]: { | ||
id: "leave-room-dialog.join-room.confirm", | ||
defaultMessage: "Join Room" | ||
}, | ||
[LeaveReason.createRoom]: { | ||
id: "leave-room-dialog.create-room.confirm", | ||
defaultMessage: "Leave and Create Room" | ||
} | ||
}); | ||
|
||
export function LeaveRoomModal({ reason, destinationUrl, onClose }) { | ||
const intl = useIntl(); | ||
|
||
return ( | ||
<Modal title="Leave Room" beforeTitle={<CloseButton onClick={onClose} />} contentClassName={styles.leaveRoomModal}> | ||
<p>{intl.formatMessage(reasonMessages[reason])}</p> | ||
<Button as="a" preset="cancel" href={destinationUrl} rel="noopener noreferrer"> | ||
{intl.formatMessage(confirmationMessages[reason])} | ||
</Button> | ||
</Modal> | ||
); | ||
} | ||
|
||
LeaveRoomModal.propTypes = { | ||
reason: PropTypes.string, | ||
destinationUrl: PropTypes.string, | ||
onClose: PropTypes.func | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
:local(.leave-room-modal) { | ||
display: flex; | ||
flex-direction: column; | ||
align-items: center; | ||
justify-content: center; | ||
text-align: center; | ||
padding: 20px; | ||
line-height: 1.25; | ||
|
||
& > * { | ||
margin-bottom: 16px; | ||
|
||
&:last-child { | ||
margin-bottom: 0; | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
import React from "react"; | ||
import { RoomLayout } from "../layout/RoomLayout"; | ||
import { LeaveReason, LeaveRoomModal } from "./LeaveRoomModal"; | ||
|
||
export default { | ||
title: "LeaveRoomModal", | ||
parameters: { | ||
layout: "fullscreen" | ||
}, | ||
args: { | ||
destinationUrl: "#" | ||
} | ||
}; | ||
|
||
export const LeaveRoom = args => <RoomLayout modal={<LeaveRoomModal reason={LeaveReason.joinRoom} {...args} />} />; | ||
|
||
export const CreateRoom = args => <RoomLayout modal={<LeaveRoomModal reason={LeaveReason.createRoom} {...args} />} />; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might also be good to flow thru this modal as a confirmation step for visiting rooms via a room link. I've accidentally clicked one before and it would have been nice to back out of it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, that would break the flow of things like Chamberlain's lighthouse experience though. I don't know that I agree with this, but I'd be happy to follow up discussion in another issue.