Python: Parse glean.h header at build time #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travis79
approved these changes
Apr 29, 2020
mdboom
force-pushed
the
python-cffi-parse-at-build-time
branch
2 times, most recently
from
ae34b1e to
41ba457
Compare
mdboom
force-pushed
the
python-cffi-parse-at-build-time
branch
from
41ba457 to
126ffb6
Compare
mdboom
force-pushed
the
python-cffi-parse-at-build-time
branch
from
0499834 to
becebad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the instructions in the CFFI docs to parse the glean.h header at build time, rather than run time.
This improves the time of
import gleanfrom 301ms to 0.3ms. Seems like a big win, particularly for commandline apps that may run multiple times as part of a build, etc.