-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new flag to pings: send_if_empty #528
Conversation
Codecov Report
@@ Coverage Diff @@
## master #528 +/- ##
============================================
- Coverage 75.93% 75.92% -0.01%
Complexity 333 333
============================================
Files 96 96
Lines 5643 5649 +6
Branches 700 703 +3
============================================
+ Hits 4285 4289 +4
Misses 842 842
- Partials 516 518 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, just some minor discussion points below.
glean-core/android/src/main/java/mozilla/telemetry/glean/private/PingType.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r+ wc
f56278d
to
e985e1e
Compare
e985e1e
to
b1a517d
Compare
No description provided.