Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new flag to pings: send_if_empty #528

Merged
merged 6 commits into from
Nov 28, 2019
Merged

Add a new flag to pings: send_if_empty #528

merged 6 commits into from
Nov 28, 2019

Conversation

badboy
Copy link
Member

@badboy badboy commented Nov 26, 2019

No description provided.

@codecov-io
Copy link

codecov-io commented Nov 26, 2019

Codecov Report

Merging #528 into master will decrease coverage by <.01%.
The diff coverage is 63.63%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #528      +/-   ##
============================================
- Coverage     75.93%   75.92%   -0.01%     
  Complexity      333      333              
============================================
  Files            96       96              
  Lines          5643     5649       +6     
  Branches        700      703       +3     
============================================
+ Hits           4285     4289       +4     
  Misses          842      842              
- Partials        516      518       +2
Impacted Files Coverage Δ Complexity Δ
...n/java/mozilla/telemetry/glean/rust/LibGleanFFI.kt 66.66% <ø> (ø) 0 <0> (ø) ⬇️
glean-core/src/lib.rs 63.1% <ø> (+0.53%) 0 <0> (ø) ⬇️
glean-core/src/metrics/ping.rs 23.07% <0%> (-4.2%) 0 <0> (ø)
glean-core/ios/Glean/Metrics/Ping.swift 90.9% <100%> (ø) 0 <0> (ø) ⬇️
...n/java/mozilla/telemetry/glean/private/PingType.kt 81.81% <100%> (+1.81%) 3 <0> (ø) ⬇️
glean-core/src/ping/mod.rs 67.66% <75%> (-0.02%) 0 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 439429e...b1a517d. Read the comment docs.

Copy link
Contributor

@Dexterp37 Dexterp37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just some minor discussion points below.

glean-core/ios/Glean/Metrics/Ping.swift Outdated Show resolved Hide resolved
glean-core/src/ping/mod.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@mdboom mdboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ wc

glean-core/python/glean/metrics/ping.py Outdated Show resolved Hide resolved
@badboy badboy merged commit a172240 into master Nov 28, 2019
@badboy badboy deleted the send-if-empty branch November 28, 2019 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants