Bug 1721193 - Remove reliance on Operation for uploading tasks in the background
#1783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travis79
force-pushed
the
playing-with-ios-fire
branch
from
a560a87 to
1dd23be
Compare
|
I assume this is for bug 1721193? |
|
This certainly simplifies things. |
|
Yeah, the tests were being a pain on Friday so I opted to look into them with fresh eyes today. |
Yes, I forget we have the bug linking thing if I name my PR's correctly. |
badboy
changed the title
Operation for uploading tasks in the backgroundOperation for uploading tasks in the background
travis79
force-pushed
the
playing-with-ios-fire
branch
3 times, most recently
from
3465972 to
1c077fb
Compare
Codecov Report
@@ Coverage Diff @@
## main #1783 +/- ##
=======================================
Coverage 29.41% 29.41%
=======================================
Files 1 1
Lines 34 34
=======================================
Hits 10 10
Misses 24 24 Continue to review full report at Codecov.
|
badboy
requested changes
Sep 16, 2021
glean-core/ios/GleanTests/Metrics/DatetimeMetricTypeTests.swift
Outdated
Show resolved
Hide resolved
glean-core/ios/GleanTests/Scheduler/MetricsPingSchedulerTests.swift
Outdated
Show resolved
Hide resolved
glean-core/ios/GleanTests/Scheduler/MetricsPingSchedulerTests.swift
Outdated
Show resolved
Hide resolved
travis79
force-pushed
the
playing-with-ios-fire
branch
from
cb2c00b to
ed450c5
Compare
This relies on the background operation capabilities that are built into URLSession, which we were already using wrapped in an `Operation`. This removes the wrapping, using just the URLOperation capabilities. Update changelog
This addresses the iOS tests that are leaking pings to the ingestion pipeline and are showing up in the Glean Debug View. This wraps any call to `resetGlean` with an OHTTPStub in order to intercept the request and prevent the network activity. Most test cases just reset Glean in the `setUp` function, and so the startup pings are now intercepted so they don't interfere with the tests or escape. In some cases, where we were already using stubs as we test contents of pings, the intent of the test was maintained and any setup calls to `resetGlean` were also wrapped in a way to not interfere with these tests' intents.
travis79
force-pushed
the
playing-with-ios-fire
branch
from
ed450c5 to
65dfe08
Compare
badboy
requested changes
Sep 29, 2021
| Glean.shared.setUploadEnabled(true) | ||
| OHHTTPStubs.removeAllStubs() | ||
| expectation = nil | ||
| tearDownStubs() |
badboy
approved these changes
Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relies on the background operation capabilities that are built into URLSession, which we were already using wrapped in an
Operation. This removes the wrapping, using just the URLOperation capabilities.