Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1728681 - This adds the QuantityMetricType to the Xcode project file #1774

Merged
merged 4 commits into from
Sep 2, 2021

Conversation

travis79
Copy link
Member

@travis79 travis79 commented Sep 1, 2021

The file wasn't added for some reason and so it wasn't being built and linked into the resulting Glean framework.

The file wasn't added for some reason and so it wasn't being built and linked into the resulting Glean framework.
@auto-assign auto-assign bot requested a review from brizental September 1, 2021 22:20
@codecov
Copy link

codecov bot commented Sep 1, 2021

Codecov Report

Merging #1774 (289c1f9) into main (5cbe8ab) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1774   +/-   ##
=======================================
  Coverage   29.41%   29.41%           
=======================================
  Files           1        1           
  Lines          34       34           
=======================================
  Hits           10       10           
  Misses         24       24           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6eff407...289c1f9. Read the comment docs.

@travis79 travis79 requested review from badboy and removed request for brizental September 1, 2021 22:37
@badboy badboy merged commit e92e346 into mozilla:main Sep 2, 2021
@badboy badboy changed the title This adds the QuantityMetricType to the Xcode project file Bug 1728681 - This adds the QuantityMetricType to the Xcode project file Sep 2, 2021
@travis79 travis79 deleted the fix-ios-missing-quantitymetrictype branch September 30, 2021 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants