Bug 1673850 - Allow ping registration before RLB init #1393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dexterp37
commented
Dec 14, 2020
Dexterp37
force-pushed
the
rlb_ping_reg
branch
from
2f5f69f to
87755a6
Compare
|
I filed this bug to document testing pings. |
badboy
requested changes
Dec 15, 2020
Dexterp37
force-pushed
the
rlb_ping_reg
branch
from
5e2c4a3 to
ed36867
Compare
This is needed so that products using Glean (and tests) could register pings at an arbitrary time, even if the Glean init is deferred a bit.
Co-authored-by: Jan-Erik Rediger <[email protected]>
Dexterp37
force-pushed
the
rlb_ping_reg
branch
from
ed36867 to
4430ac0
Compare
badboy
approved these changes
Dec 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed so that products using Glean (and tests) could register pings at an arbitrary time, even if the Glean init is deferred a bit.