Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1676712 - Use the correct time unit for sleeps in Swift and Python #1325

Merged
merged 4 commits into from
Nov 17, 2020

Conversation

badboy
Copy link
Member

@badboy badboy commented Nov 17, 2020

Closes #1315

@badboy badboy requested a review from brizental November 17, 2020 10:08
Copy link
Contributor

@brizental brizental left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think C# also has this issue, but no need to include that fix on this PR I think. Maybe follow up?

@badboy
Copy link
Member Author

badboy commented Nov 17, 2020

I think C# also has this issue, but no need to include that fix on this PR I think. Maybe follow up?

Not according to the docs: https://docs.microsoft.com/en-us/dotnet/api/system.threading.thread.sleep?view=net-5.0#System_Threading_Thread_Sleep_System_Int32_

@badboy badboy merged commit b32f345 into main Nov 17, 2020
@badboy badboy deleted the correct-unit-for-sleep branch November 17, 2020 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants