Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1672982 - Implement the experiments API for the RLB #1314

Merged
merged 6 commits into from
Nov 12, 2020

Conversation

travis79
Copy link
Member

No description provided.

@travis79 travis79 marked this pull request as ready for review November 11, 2020 17:02
@travis79 travis79 requested a review from Dexterp37 November 11, 2020 17:14
Copy link
Contributor

@Dexterp37 Dexterp37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great overall, thank you for your help Travis! There's a bunch of minor requests, plus a question for Jan-Erik.

glean-core/rlb/src/lib.rs Outdated Show resolved Hide resolved
glean-core/rlb/src/lib.rs Show resolved Hide resolved
glean-core/rlb/src/private/recorded_experiment_data.rs Outdated Show resolved Hide resolved
glean-core/rlb/src/private/recorded_experiment_data.rs Outdated Show resolved Hide resolved
glean-core/rlb/src/lib.rs Outdated Show resolved Hide resolved
glean-core/rlb/src/lib.rs Outdated Show resolved Hide resolved
Co-authored-by: Jan-Erik Rediger <[email protected]>
@Dexterp37 Dexterp37 merged commit 2dc74ae into mozilla:main Nov 12, 2020
@travis79 travis79 deleted the rlb-experiment-api branch December 15, 2020 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants