Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1661240 - Have same throttle backoff time for all bindings #1240

Merged
merged 2 commits into from
Oct 13, 2020
Merged

Bug 1661240 - Have same throttle backoff time for all bindings #1240

merged 2 commits into from
Oct 13, 2020

Conversation

brizental
Copy link
Contributor

No description provided.

@brizental brizental requested a review from badboy September 30, 2020 11:38
@brizental brizental changed the title Bug 1613944 - Have same throttle backoff time for all bindings Bug 1661240 - Have same throttle backoff time for all bindings Sep 30, 2020
badboy
badboy requested changes Oct 1, 2020
View reviewed changes
Copy link
Member

@badboy badboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comment, I think this introduces a problem on iOS (well, the problem was already there, this would just amplify it)

glean-core/python/glean/glean.py Show resolved Hide resolved
glean-core/ios/Glean/Net/HttpPingUploader.swift Show resolved Hide resolved
@brizental brizental added the blocked Blocked pull requests and issues label Oct 2, 2020
@badboy badboy mentioned this pull request Oct 9, 2020
Merged
@badboy badboy removed the blocked Blocked pull requests and issues label Oct 9, 2020
@brizental brizental requested a review from badboy October 9, 2020 15:16
@badboy
Copy link
Member

badboy commented Oct 9, 2020

Can you rebase that on latest main? then we can trigger the iOS CI jobs again

@brizental brizental force-pushed the 1661240-standardize-backoff branch from d81385c to 620b46f Compare October 12, 2020 08:04
badboy
badboy approved these changes Oct 13, 2020
View reviewed changes
Copy link
Member

@badboy badboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a changelog entry, please?
Otherwise this is now good to go.

@brizental brizental force-pushed the 1661240-standardize-backoff branch from 2467922 to 6c8895c Compare October 13, 2020 08:24
@brizental brizental merged commit 2261845 into mozilla:main Oct 13, 2020
@brizental brizental deleted the 1661240-standardize-backoff branch October 13, 2020 08:53
fviard added a commit to fviard/glean that referenced this pull request Nov 11, 2020
@fviard
Bug 1676712: Reduce throttle backoff time to 1s and fixes it for pyth…
01642f5 
…on and swift

Fixes regression introduced by PR mozilla#1240 :
Python and Swift "sleep" functions are expecting "seconds" and not ms.
@fviard fviard mentioned this pull request Nov 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@badboy badboy badboy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brizental @badboy