Bug 1655613 - Work around a crash on Android 8 buggy devices #1135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dexterp37
changed the title
badboy
approved these changes
Aug 6, 2020
glean-core/android/src/main/java/mozilla/telemetry/glean/scheduler/MetricsPingScheduler.kt
Show resolved
Hide resolved
glean-core/android/src/main/java/mozilla/telemetry/glean/scheduler/MetricsPingScheduler.kt
Show resolved
Hide resolved
This works around a bug in the Java compiler on some Android 8/8.1 devices (SDK=25). See [here](https://issuetracker.google.com/issues/110848122#comment17) for more details. On buggy devices, an `AssertionError` is raised because the timezone name `enum` switch is compiled into racy code. Since we only use the timezone name in our logs, we can safely swap that out. We don't need this defensive programming in `DateUtis.kt` as we're not using timezone names there.
Dexterp37
force-pushed
the
android_tz_crash
branch
from
514aa12 to
ae4f056
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works around a bug in the Java compiler on some Android 8/8.1 devices (SDK=25). See here for more details. On buggy devices, an
AssertionErroris raised because the timezone nameenumswitch is compiled into racy code. Since we only use the timezone name in our logs, we can safely swap that out.We don't need this defensive programming in
DateUtis.ktas we're not using timezone names there.