Bug 1653244 - Fix experiment info getting cleared before getting into metrics ping #1069
Conversation
There was a problem hiding this comment.
LGTM -- but maybe this one especially should have @Dexterp37's eye given the metrics ping scheduler involvement?
Does Swift also suffer the same issue and should we file a bug to do that work?
Swift, fortunately, does not suffer from this so nothing to change there. This appeared to be an Android only issue, and only since init was made async. |
| @@ -201,10 +201,10 @@ internal class MetricsPingScheduler( | |||
| if (isDifferentVersion()) { | |||
There was a problem hiding this comment.
Please add a changelog entry for this!
| @@ -510,10 +511,15 @@ class MetricsPingSchedulerTest { | |||
| val expectedValue = "canary" | |||
| expectedStringMetric.set(expectedValue) | |||
|
|
|||
| // Set an experiment active to verify it gets sent in the pings | |||
| Glean.setExperimentActive("test-experiment", "a") | |||
There was a problem hiding this comment.
This should really be an integration test for our sample app, along with most of the tests in this file. Nothing you can do here, though - this whole thing would require its own bug. @travis79 would you kindly file it?
… metrics ping This is the fix for the Android/Kotlin bindings and a modified test to cover the case.
Fix wording
This is the fix for the Android/Kotlin bindings and a modified test to cover the case.