Bug 1646706 - Manage log_pings from core and add docs about debugging through env vars #1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brizental
commented
Jul 14, 2020
brizental
commented
Jul 14, 2020
|
|
||
| while (task.tag != FfiPingUploadTask_Done) { | ||
| printf("tag: %d\n", task.tag); | ||
|
|
||
| if (task.tag == FfiPingUploadTask_Upload) { | ||
| printf("path: %s\n", task.upload.path); | ||
| printf("body length: %lld\n", task.upload.body.len); | ||
| printf("body length: %d\n", task.upload.body.len); |
There was a problem hiding this comment.
I was getting a warning about this everytime I built the C app. Was there a reason for the previous choice?
There was a problem hiding this comment.
cc -I.. -o glean_app glean_app.c ../../../target/debug/libglean_ffi.dylib
glean_app.c:55:41: warning: format specifies type 'long long' but the argument has type
'int32_t' (aka 'int') [-Wformat]
printf("body length: %lld\n", task.upload.body.len);
~~~~ ^~~~~~~~~~~~~~~~~~~~
%d
brizental
commented
Jul 14, 2020
This is important because test run in parallel, if both tests are changing the same env var at the same time, we get intermittent failures.
brizental
force-pushed
the
1646706-debug-env-2
branch
from
83e6759 to
18f80af
Compare
brizental
changed the title
travis79
reviewed
Jul 14, 2020
glean-core/android/src/main/java/mozilla/telemetry/glean/config/Configuration.kt
Outdated
Show resolved
Hide resolved
Dexterp37
requested changes
Jul 14, 2020
glean-core/android/src/main/java/mozilla/telemetry/glean/Glean.kt
Outdated
Show resolved
Hide resolved
glean-core/android/src/main/java/mozilla/telemetry/glean/config/Configuration.kt
Outdated
Show resolved
Hide resolved
glean-core/android/src/main/java/mozilla/telemetry/glean/config/Configuration.kt
Show resolved
Hide resolved
travis79
requested changes
Jul 14, 2020
4 tasks
* Separate env vars text in it's own section on iOS docs * Remove env vars text from Android docs and add note about it * Correct exposure of methods in kt and swift * Set default value of `false` to logPings in kt and swift * Set logPings to true before init for tests setup in kt and swift
Dexterp37
approved these changes
Jul 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also fix an intermittent test failure introduced by the previous PR, I didn't realize this was a problem until I ran some final tests before pushing this branch.
This changes will also fix https://bugzilla.mozilla.org/show_bug.cgi?id=1648007 and https://bugzilla.mozilla.org/show_bug.cgi?id=1648012 for free, in case we only want C# and Python to manage debug optins through environment variables.
Finally I also add docs about debugging through environment variables here.