Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1647782 - Set the correct value in app_build from Python #1031

Merged
merged 3 commits into from
Jul 6, 2020

Conversation

Dexterp37
Copy link
Contributor

See the individual commit messages. We were setting application_id there, mistakenly.

Dexterp37 added 2 commits July 1, 2020 10:09
This adds a configuration option to `Glean.initialize`
in the python language bindings to provide an app build
id from an external source.
@Dexterp37 Dexterp37 changed the title Set the correct value in app_build from Python Bug 1647782 - Set the correct value in app_build from Python Jul 1, 2020
@auto-assign auto-assign bot requested a review from mdboom July 1, 2020 08:13
@Dexterp37 Dexterp37 self-assigned this Jul 1, 2020
Copy link
Contributor

@mdboom mdboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@Dexterp37 Dexterp37 merged commit 5524e35 into mozilla:main Jul 6, 2020
@Dexterp37 Dexterp37 deleted the py_build_id branch July 6, 2020 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants