iOS: Disable code coverage #1195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I actually need to properly test this once more against Firefox iOS |
This avoids linker errors due to missing errors such as as "___llvm_profile_runtime". We only use code coverage in development for our manual checks, but we should not put that in released binary frameworks.
badboy
force-pushed
the
disable-code-coverage-in-release
branch
from
2513969 to
7de6b1e
Compare
badboy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids linker errors due to missing errors such as as "___llvm_profile_runtime".
We only use code coverage in development for our manual checks, but we
should not put that in released binary frameworks.