Skip to content

Commit

Permalink
iOS: Disable code coverage in release and debug builds
Browse files Browse the repository at this point in the history
This avoids linker errors due to missing errors such as as "___llvm_profile_runtime".
We only use code coverage in development for our manual checks, but we
should not put that in released binary frameworks.
  • Loading branch information
badboy committed Aug 28, 2020
1 parent 864cf8e commit 7de6b1e
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

* General
* Track the size of the database file at startup ([#1141](https://github.com/mozilla/glean/pull/1141)).
* iOS
* Disabled code coverage in release builds ([#1195](https://github.com/mozilla/glean/issues/1195)).

# v32.3.0 (2020-08-27)

Expand Down
3 changes: 3 additions & 0 deletions glean-core/ios/Glean.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -719,6 +719,7 @@
CLANG_ANALYZER_NUMBER_OBJECT_CONVERSION = YES_AGGRESSIVE;
CLANG_CXX_LANGUAGE_STANDARD = "gnu++14";
CLANG_CXX_LIBRARY = "libc++";
CLANG_ENABLE_CODE_COVERAGE = NO;
CLANG_ENABLE_MODULES = YES;
CLANG_ENABLE_OBJC_ARC = YES;
CLANG_ENABLE_OBJC_WEAK = YES;
Expand Down Expand Up @@ -773,6 +774,7 @@
isa = XCBuildConfiguration;
baseConfigurationReference = BF51C3B9224BF19F0014CBAF /* debug.xcconfig */;
buildSettings = {
CLANG_ENABLE_CODE_COVERAGE = NO;
CLANG_ENABLE_MODULES = YES;
CODE_SIGN_IDENTITY = "";
CODE_SIGN_STYLE = Manual;
Expand Down Expand Up @@ -807,6 +809,7 @@
isa = XCBuildConfiguration;
baseConfigurationReference = BF51C3BA224BF19F0014CBAF /* release.xcconfig */;
buildSettings = {
CLANG_ENABLE_CODE_COVERAGE = NO;
CLANG_ENABLE_MODULES = YES;
CODE_SIGN_IDENTITY = "";
CODE_SIGN_STYLE = Manual;
Expand Down

0 comments on commit 7de6b1e

Please sign in to comment.