Merge pull request #1252 from mozilla/ios/async-upload-processing

Bug 1668820 - Always launch the ping uploader on a background thread
mozilla · Oct 9, 2020 · e83abba · e83abba
2 parents eda285f + 94169de
commit e83abba
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 5 deletions.
diff --git a/glean-core/ios/Glean/Glean.swift b/glean-core/ios/Glean/Glean.swift
@@ -158,7 +158,7 @@ public class Glean {
             // 1. Pings were submitted through Glean and it is ready to upload those pings;
             // 2. Upload is disabled, to upload a possible deletion-request ping.
             if pingSubmitted || !uploadEnabled {
-                HttpPingUploader(configuration: configuration).process()
+                HttpPingUploader.launch(configuration: configuration)
             }
 
             // Check for overdue metrics pings
@@ -270,9 +270,7 @@ public class Glean {
 
             if originalEnabled && !enabled {
                 // If uploading is disabled, we need to send the deletion-request ping
-                Dispatchers.shared.launchConcurrent {
-                    HttpPingUploader(configuration: self.configuration!).process()
-                }
+                HttpPingUploader.launch(configuration: self.configuration!)
             }
         }
     }
@@ -456,7 +454,7 @@ public class Glean {
 
         if submittedPing != 0 {
             if let config = self.configuration {
-                HttpPingUploader(configuration: config).process()
+                HttpPingUploader.launch(configuration: config)
             }
         }
     }

diff --git a/glean-core/ios/Glean/Net/HttpPingUploader.swift b/glean-core/ios/Glean/Net/HttpPingUploader.swift
@@ -33,6 +33,15 @@ public class HttpPingUploader {
         self.config = configuration
     }
 
+    /// Launch a new ping uploader on the background thread.
+    ///
+    /// This function doesn't block.
+    static func launch(configuration: Configuration) {
+        Dispatchers.shared.launchConcurrent {
+            HttpPingUploader(configuration: configuration).process()
+        }
+    }
+
     /// Synchronously upload a ping to Mozilla servers.
     ///
     /// - parameters: