Skip to content

Commit

Permalink
Log informational line when handling active/inactive
Browse files Browse the repository at this point in the history
Submitting can't hard-fail anymore, so we can reduce our warning to info
here.
  • Loading branch information
badboy committed May 4, 2021
1 parent 1bf066e commit b18526d
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions glean-core/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -923,7 +923,7 @@ impl Glean {
/// and then sets the dirty bit.
pub fn handle_client_active(&mut self) {
if !self.internal_pings.baseline.submit(self, Some("active")) {
log::warn!("Failed to submit baseline ping on active");
log::info!("baseline ping not submitted on active");
}

self.set_dirty_flag(true);
Expand All @@ -935,11 +935,11 @@ impl Glean {
/// `inactive` and then clears the dirty bit.
pub fn handle_client_inactive(&mut self) {
if !self.internal_pings.baseline.submit(self, Some("inactive")) {
log::warn!("Failed to submit baseline ping on inactive");
log::info!("baseline ping not submitted on inactive");
}

if !self.internal_pings.events.submit(self, Some("inactive")) {
log::warn!("Failed to submit events ping on inactive");
log::info!("events ping not submitted on inactive");
}

self.set_dirty_flag(false);
Expand Down

0 comments on commit b18526d

Please sign in to comment.