Skip to content

Commit

Permalink
Address comments from PR
Browse files Browse the repository at this point in the history
  • Loading branch information
mdboom committed Mar 11, 2020
1 parent 1fa967e commit 6ad5cb1
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 9 deletions.
6 changes: 3 additions & 3 deletions docs/user/metrics/labeled_booleans.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ assertTrue(Accessibility.features["high_contrast"].testHasValue())
assertEquals(True, Accessibility.features["screen_reader"].testGetValue())
assertEquals(False, Accessibility.features["high_contrast"].testGetValue())
// Did we record any invalid labels?
assertEquals(1, Accessibility.features.testGetNumRecordedErrors(ErrorType.InvalidLabel))
assertEquals(0, Accessibility.features.testGetNumRecordedErrors(ErrorType.InvalidLabel))
```

</div>
Expand Down Expand Up @@ -96,7 +96,7 @@ assert metrics.accessibility.features["high_contrast"].test_has_value()
assert metrics.accessibility.features["screen_reader"].test_get_value()
assert not metrics.accessibility.features["high_contrast"].test_get_value()
# Did we record any invalid labels?
assert 1 == metrics.accessibility.features.test_get_num_recorded_errors(
assert 0 == metrics.accessibility.features.test_get_num_recorded_errors(
ErrorType.INVALID_LABEL
)
```
Expand All @@ -113,7 +113,7 @@ assert 1 == metrics.accessibility.features.test_get_num_recorded_errors(

* Each label must have a maximum of 60 bytes, when encoded as UTF-8.

* If the labels are specified in the `metrics.yaml`, using a different label will be replaced with the special value `__other__`.
* If the labels are specified in the `metrics.yaml`, using any label not listed in that file will be replaced with the special value `__other__`.

* If the labels aren't specified in the `metrics.yaml`, only 16 different dynamic labels may be used, after which the special value `__other__` will be used.

Expand Down
6 changes: 3 additions & 3 deletions docs/user/metrics/labeled_counters.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ assertTrue(Stability.crashCount["native_code_crash"].testHasValue())
assertEquals(1, Stability.crashCount["uncaught_exception"].testGetValue())
assertEquals(3, Stability.crashCount["native_code_crash"].testGetValue())
// Did we record any invalid labels?
assertEquals(1, Stability.crashCount.testGetNumRecordedErrors(ErrorType.InvalidLabel))
assertEquals(0, Stability.crashCount.testGetNumRecordedErrors(ErrorType.InvalidLabel))
```

</div>
Expand Down Expand Up @@ -94,7 +94,7 @@ assert metrics.stability.crash_count["native_code_crash"].test_has_value()
assert 1 == metrics.stability.crash_count["uncaught_exception"].test_get_value()
assert 3 == metrics.stability.crash_count["native_code_crash"].test_get_value()
# Did we record any invalid labels?
assert 1 == metrics.stability.crash_count.test_get_num_recorded_errors(
assert 0 == metrics.stability.crash_count.test_get_num_recorded_errors(
ErrorType.INVALID_LABEL
)
```
Expand All @@ -111,7 +111,7 @@ assert 1 == metrics.stability.crash_count.test_get_num_recorded_errors(

* Each label must have a maximum of 60 bytes, when encoded as UTF-8.

* If the labels are specified in the `metrics.yaml`, using a different label will be replaced with the special value `__other__`.
* If the labels are specified in the `metrics.yaml`, using any label not listed in that file will be replaced with the special value `__other__`.

* If the labels aren't specified in the `metrics.yaml`, only 16 different dynamic labels may be used, after which the special value `__other__` will be used.

Expand Down
6 changes: 3 additions & 3 deletions docs/user/metrics/labeled_strings.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ import org.mozilla.yourApplication.GleanMetrics.Login
assertTrue(Login.errorsByStage["server_auth"].testHasValue())

// Were there any invalid labels?
assertEquals(1, Login.errorsByStage.testGetNumRecordedErrors(ErrorType.InvalidLabel))
assertEquals(0, Login.errorsByStage.testGetNumRecordedErrors(ErrorType.InvalidLabel))
```

</div>
Expand Down Expand Up @@ -78,7 +78,7 @@ There are test APIs available too:
assert metrics.login.errors_by_stage["server_auth"].test_has_value()

# Were there any invalid labels?
assert 1 == metrics.login.errors_by_stage.test_get_num_recorded_errors(
assert 0 == metrics.login.errors_by_stage.test_get_num_recorded_errors(
ErrorType.INVALID_LABEL
)
```
Expand All @@ -94,7 +94,7 @@ assert 1 == metrics.login.errors_by_stage.test_get_num_recorded_errors(

* Each label must have a maximum of 60 bytes, when encoded as UTF-8.

* If the labels are specified in the `metrics.yaml`, using a different label will be replaced with the special value `__other__`.
* If the labels are specified in the `metrics.yaml`, using any label not listed in that file will be replaced with the special value `__other__`.

* If the labels aren't specified in the `metrics.yaml`, only 16 different dynamic labels may be used, after which the special value `__other__` will be used.

Expand Down

0 comments on commit 6ad5cb1

Please sign in to comment.