Refactor package.json (fixes #317) #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iinh
suggested changes
Jul 22, 2021
There was a problem hiding this comment.
Hi @chichi012 looks like some of the tests didn't pass, I think we might be having some linting issues. Please see the Code Quality guide to lint your code, and make sure that all tests pass locally before pushing. Let me know if you have any questions.
chichi012
force-pushed
the
update-dependencies
branch
from
396c453 to
4390f5a
Compare
|
@Iinh I have been able to rectify the issue and I tested it locally. Thanks for the help. |
Iinh
approved these changes
Jul 23, 2021
|
Thank you for your help! @Iinh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merged the dependencies in "dependencies" into "devDependencies".