Add a link to GLAM for the selected metric #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wlach
suggested changes
Jan 8, 2021
robhudson
commented
Jan 8, 2021
wlach
suggested changes
Jan 11, 2021
src/pages/MetricDetail.svelte
Outdated
| @@ -197,6 +225,15 @@ | |||
| {/each} | |||
| </td> | |||
| </tr> | |||
| {#if glamUrl} | |||
There was a problem hiding this comment.
Argh, sorry, did some last minute testing and it looks like this doesn't do the right thing for events (it incorrectly suggests we can view them in GLAM). Maybe the suggestion below will fix that?
Suggested change
| {#if glamUrl} | |
| {#if glamUrl && metric.type !== "event"} |
There was a problem hiding this comment.
Cool, thanks. I added a condition similar to one just above it. Let me know if that's correct. It worked locally for me.
robhudson
force-pushed
the
279-link-glam
branch
from
fe55e40 to
6175968
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.