Allow search results to be filtered by name only #2114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Dexterp37 could you review this PR? Thanks 🙇♀️ |
Dexterp37
approved these changes
Feb 12, 2024
| const searchIndex = generateSearchIndex(searchItems); | ||
|
|
||
| searchTerms.forEach((term) => { | ||
| if ( | ||
| term.startsWith("tags:") || | ||
| term.startsWith("origin:") || | ||
| term.startsWith("type:") || | ||
| term.startsWith("expires:") |
There was a problem hiding this comment.
If you think this is going to grow, we might considering changing this in the future to something like
if (Object.keys(labels).filter(label => term.startsWith(label)).length > 0) {
Or something like that. No need to right now, just food for thought :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2113.
This PR introduces a new search filter that allows searching by names only. For example searching
name:browser.search.will return only these results.https://deploy-preview-2114--glean-dictionary-dev.netlify.app/apps/fenix?page=1&search=name%3Abrowser.search
Pull Request checklist
fixes, if applicable)