Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show whether a ping includes a client indentifier #2042

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Show whether a ping includes a client indentifier #2042

merged 1 commit into from
Dec 5, 2023

Conversation

Iinh
Copy link
Contributor

@Iinh Iinh commented Dec 4, 2023 •
edited
Loading

Fixes #2010.

Screenshot 2023-12-04 at 2 37 01 PM

Pull Request checklist

  • The pull request has a descriptive title (and a reference to an issue it
    fixes, if applicable)
  • All tests and linter checks are passing
  • The pull request is free of merge conflicts

@Iinh Iinh marked this pull request as ready for review December 4, 2023 19:38
@Iinh Iinh requested a review from chutten December 4, 2023 19:38
chutten
chutten approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@chutten chutten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@Iinh Iinh merged commit 34fe167 into main Dec 5, 2023
7 checks passed
@Iinh Iinh deleted the show-client-idenifier branch December 5, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chutten chutten chutten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

includes_client_id probably ought to be exposed in ping details pages
2 participants
@Iinh @chutten