-
Notifications
You must be signed in to change notification settings - Fork 2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Bug 1898032 [wpt PR 46407] - HTML Focusgroup attribute value rename, …
…a=testonly Automatic update from web-platform-tests HTML Focusgroup attribute value rename In a recent update to the spec (see OpenUI bug openui/open-ui#859 and spec update at https://open-ui.org/components/focusgroup.explainer/ the focusgroup direction have changed from physical descriptions "horizontal" and "vertical" to logical CSS terms that imply the direction limitations adapt to content direction: "inline" and "block". This change (my first), is a simple rename of terms "horizontal" and "vertical" to "inline" and "block" respectively. Other than the attribute value parsing changes and related enums and function names, this change does not actually [yet] consider the inline and block direction when handling directional arrow keys from user input. That will be saved for a future change. Specific changes in this CL: - `FocusgroupFlags::kHorizontal` --> `::kInline` - `FocusgroupFlags::kVertical` --> `::kBlock` - `FocusgroupFlags::kWrapHorizontally` --> `::kWrapInline` - `FocusgroupFlags::kWrapVertically` --> `::kWrapBlock` - `FocusgroupFlags::kWrapVertically` --> `::kWrapBlock` - `FocusgroupDirection::kForwardHorizontal` --> `::kForwardInline` - `FocusgroupDirection::kForwardVertical` --> `::kForwardBlock` - `FocusgroupDirection::kBackwardHorizontal` --> `::kBackwardInline` - `FocusgroupDirection::kBackwardVertical` --> `::kBackwardBlock` - `FocusgroupControllerUtils::IsDirectionHorizontal()` -> `IsDirectionInline()` - `FocusgroupControllerUtils::IsDirectionVertical()` -> `IsDirectionBlock()` Web tests impacted by this change are updated (and the corresponding spec link is also updated). Bug: 40210717 Change-Id: Ic3c9a5dc56c0d48f8c1aa5c5cec3dc70bb1f5687 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5554766 Commit-Queue: Benjamin Beaudry <[email protected]> Reviewed-by: Benjamin Beaudry <[email protected]> Reviewed-by: Mason Freed <[email protected]> Cr-Commit-Position: refs/heads/main@{#1305376} -- wpt-commits: 9afafe0bc71a4276422b3f2d725ddfbf4e0225c5 wpt-pr: 46407
- Loading branch information
1 parent
1fe5ee1
commit e494b38
Showing
32 changed files
with
77 additions
and
77 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.