Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for redis deduplication #1583

Merged
merged 2 commits into from
Mar 11, 2021
Merged

Remove support for redis deduplication #1583

merged 2 commits into from
Mar 11, 2021

Conversation

relud
Copy link
Contributor

@relud relud commented Feb 26, 2021

marking draft because this should not be merged until redis is actually disabled.

@relud relud requested a review from jklukas February 26, 2021 19:10
Copy link
Contributor

@jklukas jklukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We'll also need to make sure that the deploy logic is no longer referencing these options before merging.

@whd whd marked this pull request as ready for review March 11, 2021 22:09
@codecov-io
Copy link

codecov-io commented Mar 11, 2021

Codecov Report

Merging #1583 (20836e1) into master (608089c) will decrease coverage by 3.87%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1583      +/-   ##
============================================
- Coverage     86.15%   82.28%   -3.88%     
+ Complexity      764      658     -106     
============================================
  Files           110       81      -29     
  Lines          4608     3454    -1154     
  Branches        427      374      -53     
============================================
- Hits           3970     2842    -1128     
+ Misses          498      487      -11     
+ Partials        140      125      -15     
Flag Coverage Δ Complexity Δ
ingestion_beam 82.28% <ø> (-0.01%) 0.00 <ø> (ø)
ingestion_edge ? ?
ingestion_sink ? ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...m/src/main/java/com/mozilla/telemetry/Decoder.java 97.29% <ø> (-0.14%) 10.00 <0.00> (ø)
...c/main/java/com/mozilla/telemetry/Republisher.java 100.00% <ø> (ø) 12.00 <0.00> (ø)
.../com/mozilla/telemetry/decoder/DecoderOptions.java 100.00% <ø> (ø) 2.00 <0.00> (-1.00)
...illa/telemetry/republisher/RepublisherOptions.java 100.00% <ø> (ø) 2.00 <0.00> (-2.00)
...tion/core/transform/PubsubMessageToObjectNode.java 72.02% <0.00%> (-11.89%) 3.00% <0.00%> (ø%)
...etry/ingestion/core/util/DerivedAttributesMap.java 96.00% <0.00%> (-4.00%) 15.00% <0.00%> (-1.00%)
...com/mozilla/telemetry/ingestion/sink/util/Env.java
ingestion-edge/ingestion_edge/flush.py
ingestion-edge/ingestion_edge/flush_manager.py
...a/telemetry/ingestion/sink/io/WriteWithErrors.java
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 608089c...20836e1. Read the comment docs.

@whd whd merged commit c05fbab into master Mar 11, 2021
@whd whd deleted the remove-redis branch March 11, 2021 22:14
jklukas added a commit that referenced this pull request May 24, 2021
relud pushed a commit that referenced this pull request May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants