This repository has been archived by the owner on Apr 3, 2019. It is now read-only.
chore(logging): updates for sentry #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladikoff
approved these changes
Nov 7, 2018
| @@ -11,6 +11,10 @@ path = "src/bin/service.rs" | |||
| name = "fxa_email_queues" | |||
| path = "src/bin/queues.rs" | |||
|
|
|||
| [profile.release] | |||
| # Include debug symbols to make Sentry errors richer | |||
| debug = true | |||
There was a problem hiding this comment.
nice! I thought it set this automatically 👍
We were sending errors to Sentry at the point where they are logged, but there are a number of paths where an error is raised without being logged. Instead, this change captures them at the point of creation, which should mean we now capture every error.
philbooth
force-pushed
the
pb/sentry-updates
branch
from
5faef07 to
0a2d39a
Compare
This was referenced Nov 19, 2018
Just noting that this had the desired effect, we now get line numbers in the stack traces. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #222.
In 4636112, I update the Sentry dependency to the latest version.
In bfeb745, I move the point at which we capture errors for Sentry, so that we now catch every error rather than just those which are logged.
In 5faef07, I turn on debug symbols in the release build, so that Sentry errors contain richer information.
@mozilla/fxa-devs r?