-
Notifications
You must be signed in to change notification settings - Fork 19
[WIP] Add a directory coverage viewer. #222
base: master
Are you sure you want to change the base?
Conversation
826f45b
to
17af400
Compare
Exciting! Give me a heads up when you think this is closer to being ready to be reviewed. |
This would be for free when you do:
|
Thanks for the feedback! Instead of re-implementing a full separate This would address the first three items in the checklist. |
17af400
to
a944c05
Compare
This new commit is still very much work-in-progress, but it makes This could allow comparing ActiveData results with our new backend (but today, I don't think they are any revisions in common between both, so instead I'm fetching EDIT: Note that I'll soon remove the pointless "raw file" view of the directory. I just kept it temporarily in order to compare results between hg.m.o / ActiveData / coverage.moz.tools (and for example, |
a944c05
to
6f34e23
Compare
6f34e23
to
17e15bb
Compare
Fixes #176.
This is a rough prototype showing per-directory coverage data:
It hijacks
Routes
by replacingFileViewerContainer
with a newDirectoryViewerContainer
component when the requested file path ends with/
(I'd like to find a cleaner solution to identify directories from files), and it uses an ActiveData query to aggregate coverage by sub-file and sub-folder (I'd like to switch to the faster https://coverage.staging.moz.tools/v2/path endpoint).TODO:
/
)fileViewer.jsx
anddirectoryViewer.jsx
This change is