fix: normalizeMethodCall should expect a CallExpression node #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mozfreddyb I did notice this while I was giving one last review pass to #169 (it was triggered by the Grammarly extension attached to mozilla/addons/issues#1263). |
mozfreddyb
approved these changes
Aug 24, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do already expect "ArrowFunctionExpression" in normalizeMethodCall, and so it seems reasonable to also expect "CallExpression" (and return an empty method name as we are doing for the "ArrowFunctionExpression").
At the moment code like the one in the test case is triggering the additonal linting issue that we log for unexpected cases we would like to be reported as new issue in this repo.