Free cbindgen from rustc-internal dynamic lib dependencies #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh I should probably update the travis.yml file as well, it will likely fail builds on non-nightly |
…avis.yml accordingly
|
Awesome, thanks Kats! It works locally for me, I'll merge and try and publish this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates cbindgen to use standalone-syn which in turn uses standalone-quote and standalone-proc-macro2, all of which use rustc-ap-proc_macro, which is a fork of the libproc_macro in rustc. This is a workaround for rust-lang/rust#47931 which allows the cbindgen binary to run without requiring all users to hack the LD_LIBRARY_PATH to pick up rustc internal dynamic libraries.